Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: add Interactive Queries docs #65

Closed
wants to merge 1 commit into from

Conversation

dguy
Copy link
Contributor

@dguy dguy commented Jul 6, 2017

No description provided.

@dguy
Copy link
Contributor Author

dguy commented Jul 6, 2017

@guozhangwang

@guozhangwang
Copy link
Contributor

Actually I think we do not need a PR for this: as a committer anyone can do the docs jar packaging -> pasting to kafka-site and push to asf-site branch. You can follow this step of the release process here:

https://cwiki.apache.org/confluence/display/KAFKA/Release+Process#ReleaseProcess-Websiteupdateprocess

@dguy
Copy link
Contributor Author

dguy commented Jul 7, 2017

Can't i just merge this PR? The process there seems more about creating a new version for a release, i.e, i don't want to update everything

@guozhangwang
Copy link
Contributor

Generally speaking separate commits on kafka and kafka-site may have the risk of diverge on these two repos if people forget to make the corresponding changes to kafka-site while pushed to kafka etc.

Re-package the docs to kafka-site won't update everything as long as it is from the corresponding branch (i.e. 0.11.0 in this case), the affected files should only be those gets modified by the patch on kafka.

@dguy
Copy link
Contributor Author

dguy commented Jul 7, 2017

@guozhangwang , yep had the discussion with @ijuma today. Managed to break everything in the process due to changes that weren't in kafka that were in kafka-site and changes in kafka that were broken. Anyway, it was fun! ;-)

@dguy dguy closed this Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants