[KARAF-5454] - Collector socket - Add UDP protocol support #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I gonna take a look. |
jbonofre
requested changes
Nov 6, 2017
|
|
||
| # Protocol tcp(default) or udp | ||
| #protocol=tcp |
There was a problem hiding this comment.
Please avoid to do useless changes (it's just noise in the commit ;)).
|
Any update about this PR ? |
|
Sorry, I check this |
PR review fix : clean noise at the end of the default config file PR review add : update documentation
|
retest this please |
|
FAILURE --none-- |
|
Failure doesn't seem related as it's on the JMS collector. Launching a new build to verify. |
|
retest this please |
|
SUCCESS --none-- |
|
Build is now OK. |
jbonofre
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the collector-socket adding compatibility with the UDP protocol.
Use a DatagramServer instead of a ServerSocket for UDP.
Changes :
Add a new properties in the collector cfg file to define the protocol :
#Protocol tcp(default) or udp#protocol=tcpInstanciate a DatagramServer in the case of udp protocol is define in the cfg
class
org.apache.karaf.decanter.collector.socket.SocketCollector