[KARAF-4145] KAR Mojo: fix metadata generation of artifacts #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggu2810
changed the title
Problem description: * use the kmp to generate a kar that contains snapshot version * use the kmp to generate a custom distribution that fills the local repository of the distribution with the content of that kar * try to install the snapshot artifact (not using any other repository then the system directory * if your snapshots has been timestamped and a maven metadata XML does not exist on KAR creation the installation of the artifact will fail The KAR Mojo contains a workaround to use the base version of a snapshot instead of a timestamped one because it does not work in startup.properties. The metadata that is used for a snapshot artifact is generated (if not present) using the timestamped version. Also if there exists already a metadata, we can not use them without further checking for the version... Let's move the version fix in front of the metadata generation and generate the metadata for every snapshot. Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description:
repository of the distribution with the content of that kar
then the system directory
not exist on KAR creation the installation of the artifact will fail
The KAR Mojo contains a workaround to use the base version of a snapshot
instead of a timestamped one because it does not work in
startup.properties.
The metadata that is used for a snapshot artifact is generated (if not
present) using the timestamped version. Also if there exists already a
metadata, we can not use them without further checking for the
version...
Let's move the version fix in front of the metadata generation and
generate the metadata for every snapshot.
Signed-off-by: Markus Rathgeb maggu2810@gmail.com