KARAF-4273 Add only matching option to grep #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase on master ? |
|
Ok, merging ;-) 2016-08-22 14:25 GMT+02:00 Jean-Baptiste Onofré notifications@github.com:
Arnaud Vandyck |
o GrepAction:
- add only matching option to grep
- refactor GrepAction
- change with-line-numbers behaviour (more like the unix grep)
o GrepTest:
- add grep tests
- test class does not implement TestCase anymore
- add tests for GrepAction onlyMatching
- ignore testGrepWordRegExpWithColour: 'word' (\b) does not work like
unix grep... don't know if it's a bug or not...
- remove last linefeed in test result
|
Done ;-) |
|
Awesome, thanks ! R: @jbonofre |
|
This PR has been merged. Can you close it please ? Thanks. |
|
That's not what I call a merge ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
o GrepAction:
o GrepTest:
unix grep... don't know if it's a bug or not...