[KARAF-5173] Provide an impl of CallbackHandler #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of tests use an anonymous class implementing CallbackHandler with the same pattern, username and password. This patch introduces NamePasswordCallbackHandler and uses it where appropriate. Signed-off-by: Stephen Kitt <skitt@redhat.com>
|
R: @jbonofre |
|
retest this please |
|
Karaf passes all its tests on my system with this patch applied (and likewise on Jenkins). Is there something specific that gives you cause for concern? |
|
No, I'm just testing the connectivity between Jenkins and GitHub. We have an issue that the infra is investigating. Again, nothing wrong with the pull request itself ;) |
|
By the way "retest this please" is a keyword comment that triggers a Jenkins build on the pull request. |
|
Ah right OK, I wasn’t aware of the keyword ;-). |
JiriOndrusek
pushed a commit
to JiriOndrusek/karaf-1
that referenced
this pull request
Apr 17, 2019
…f-jdk11 [ENTESB-9783] Support Running on Java 11/fuse-karaf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of tests use an anonymous class implementing CallbackHandler
with the same pattern, username and password. This patch introduces
NamePasswordCallbackHandler and uses it where appropriate.
Signed-off-by: Stephen Kitt skitt@redhat.com