[KARAF-5315] Synchronize lock methods #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
gnodet
reviewed
Sep 18, 2017
| rc = lock; | ||
| } | ||
| return rc; | ||
| return validateDirectoryExists(lock.getPath(), "Invalid" + PROPERTY_LOCK_DIR + " system property"); |
There was a problem hiding this comment.
I think the code behaves differently if {{PROPERTY_LOCK_DIR}} is not set.
Previously, it would default to {{KARAF_BASE}}, now it returns null and will certainly cause a NPE in the constructor.
There was a problem hiding this comment.
Good point, let me change this part and keep the sync on the methods.
jbonofre
force-pushed
the
KARAF-5315
branch
from
1f19d90
to
ce72f75
Compare
|
Squashed the commits. Waiting the end of Jenkins before merging. |
jbonofre
force-pushed
the
KARAF-5315
branch
from
ce72f75
to
5761abf
Compare
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.