Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KARAF-5919] Be able to store Http Proxy list in order to keep configuration after restart #644

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

sjhiggs
Copy link
Contributor

@sjhiggs sjhiggs commented Nov 5, 2018

No description provided.

@jbonofre jbonofre self-requested a review November 5, 2018 16:09
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot !!!

@jbonofre
Copy link
Member

jbonofre commented Nov 5, 2018

I will merge as soon as Jenkins is happy.

@sjhiggs
Copy link
Contributor Author

sjhiggs commented Nov 5, 2018

Looks like Jenkins isn't happy, but I don't think it's related to the commit. Please let me know if otherwise.

@jbonofre
Copy link
Member

jbonofre commented Nov 6, 2018

@sjhiggs it's not related to your changes, it's a flaky test that I will fix.

@jbonofre
Copy link
Member

jbonofre commented Nov 6, 2018

retest this please

@jbonofre jbonofre merged commit 0290cc2 into apache:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants