Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KARAF-5854] Delete kar folder when exception occurs during installation #656

Merged
merged 1 commit into from Nov 22, 2018
Merged

[KARAF-5854] Delete kar folder when exception occurs during installation #656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion kar/src/main/java/org/apache/karaf/kar/internal/KarServiceImpl.java
View file
Open in desktop
Expand Up @@ -102,8 +102,8 @@ public void install(URI karUri, File repoDir, File resourceDir) throws Exception
@Override
public void install(URI karUri, File repoDir, File resourceDir, boolean noAutoStartBundles) throws Exception {
busy.set(true);
Kar kar = new Kar(karUri);
try {
Kar kar = new Kar(karUri);
kar.extract(repoDir, resourceDir);
writeToFile(kar.getFeatureRepos(), new File(repoDir, FEATURE_CONFIG_FILE));
for (URI uri : kar.getFeatureRepos()) {
Expand Down Expand Up @@ -141,6 +141,11 @@ public void install(URI karUri, File repoDir, File resourceDir, boolean noAutoSt
}
delayedDeployerThread = null;
}
} catch (Exception e) {
// cleanup state if exception occurs during installation
deleteRecursively(new File(storage, kar.getKarName()));
// throw the exception to the "clients"
throw e;
} finally {
busy.set(false);
}
Expand Down