Apply pre-commit checks to all files and make CI green #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sharanf @Humbedooh - there's a lot of changes but they were automatically done by pre-commit (removing ending whitespaces and adding missing new lines at the end of files) |
|
I've only checked about 10% of the changes, but yeah looks like generic linting. |
Yes, I only applied auto changes. And using them for last year I'm sure there's no functional change |
Merged
turbaszek
added a commit
to PolideaInternal/kibble
that referenced
this pull request
Oct 17, 2020
turbaszek
added a commit
to PolideaInternal/kibble
that referenced
this pull request
Oct 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I applied all pre-commit check by running
pre-commit run --all-filesto fix the CI. Now contributors will need to care only about files they edit :)