KNOX-2155 - KnoxSSO should handle multiple cookies with the same name #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risdenk
commented
Dec 20, 2019
Comment on lines
-41
to
-52
| /** | ||
| * Encapsulate the acquisition of the JWT token from HTTP cookies within the | ||
| * request. | ||
| * | ||
| * @param req servlet request to get the JWT token from | ||
| * @return serialized JWT token | ||
| */ | ||
| @Override | ||
| protected String getJWTFromCookie(HttpServletRequest req) { | ||
| return super.getJWTFromCookie(req); | ||
| } | ||
|
|
There was a problem hiding this comment.
Will this break backwards compat if someone upgrades? I don't quite understand how these adapter classes work.
There was a problem hiding this comment.
I'm assuming no since there is no reason this method gets called anymore since its deleted everywhere?
There was a problem hiding this comment.
It should not break backwards compatibility, looks good.
gateway-util-common/src/main/java/org/apache/knox/gateway/util/CookieUtils.java
Show resolved
Hide resolved
This commit moves getting cookies by name to a new utility class. It forces callers to look through multiple cookies returned and handle that case. Signed-off-by: Kevin Risden <krisden@apache.org>
|
Merged in 1b01961 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves getting cookies by name to a
new utility class. It forces callers to look
through multiple cookies returned and handle
that case.