KNOX-2207 - TokenStateService revocation should remove persisted token state #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzampino
requested changes
Feb 4, 2020
...r/src/main/java/org/apache/knox/gateway/services/token/impl/AliasBasedTokenStateService.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/apache/knox/gateway/services/token/impl/AliasBasedTokenStateService.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/apache/knox/gateway/services/token/impl/AliasBasedTokenStateService.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/apache/knox/gateway/services/token/impl/AliasBasedTokenStateService.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/apache/knox/gateway/services/token/impl/AliasBasedTokenStateService.java
Outdated
Show resolved
Hide resolved
...rver/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java
Outdated
Show resolved
Hide resolved
...rver/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java
Outdated
Show resolved
Hide resolved
| @@ -208,6 +205,18 @@ protected void updateExpiration(final String token, long expiration) { | |||
| } | |||
| } | |||
|
|
|||
| protected void removeRevokedExpiredToken(final String token) { | |||
| if (!isValidIdentifier(token)) { | |||
There was a problem hiding this comment.
Could just call validateToken() here?
...rver/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java
Outdated
Show resolved
Hide resolved
...ver/src/main/java/org/apache/knox/gateway/services/token/impl/TokenStateServiceMessages.java
Outdated
Show resolved
Hide resolved
|
@pzampino addressed the review comments in new PR, let me know what you think. |
pzampino
requested changes
Feb 5, 2020
...rver/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java
Outdated
Show resolved
Hide resolved
...rver/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java
Outdated
Show resolved
Hide resolved
pzampino
approved these changes
Feb 5, 2020
smolnar82
reviewed
Feb 5, 2020
| aliasService.removeAliasForCluster(AliasService.NO_CLUSTER_NAME, token); | ||
| aliasService.removeAliasForCluster(AliasService.NO_CLUSTER_NAME,token + "--max"); | ||
| } catch (AliasServiceException e) { | ||
| log.failedToUpdateTokenExpiration(e); |
There was a problem hiding this comment.
This seems a misleading log message
There was a problem hiding this comment.
Right, I'll get it fixed, thanks for letting me know @smolnar82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Do not maintain state for revoked tokens.
How was this patch tested?
This patch was manually tested.
Please review Knox Contributing Process before opening a pull request.