KNOX-2368 - CM Cluster Configuration Monitor Does Not Support Rolling… #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Restart Events
What changes were proposed in this pull request?
Added cluster config monitor support for rolling restarts of individual services and complete clusters. This also fixes a previously-introduced defect whereby the monitor would recognize relevant events whose status is STARTED, which would result in false-positive inclusion of events that would trigger configuration analysis. All the relevant commands have status value of SUCCEEDED once they've successfully completed. Since the "Rolling Restart" option is disabled in the CM cluster against which I've tested, the implementation and associated test of that behavior is entirely based on log content that exposed the need for this PR.
How was this patch tested?
Refactored and augmented PollingConfigurationAnalyzerTest, and manually tested all the supported scenarios (except rolling CLUSTER restart).