KNOX-2623 - Lifespan attributes are optional on token generation UI and default to 1 hour #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd default to 1 hour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
By default, lifespan attributes (day, hour, and minute spinners) are displayed on the token generation UI. However, end-users have a way to hide these input fields by setting a newly introduced topology-level configuration, called
knox.token.lifespan.input.enabled, tofalse.In this case, the generated token will have the configured/default token TTL.
I also made the default value of the lifespan attributes to 1 hour.
How was this patch tested?
Updated the JUnit tests and executed several manual testing locally (with and w/o the lifespan properties).