KNOX-2713 - Allowing end-users to customize 'user limit exceeded' action when creating Knox tokens #543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Changing Knox's default behavior when a user exceeds the configured token limit: if
REMOVE_OLDEST
is configured, Knox will remove the oldest token instead of returning an error.How was this patch tested?
Updated existing JUnit tests as well as added new ones:
Manual testing:
gateway.knox.token.limit.per.user = 1
ingateway-site.xml
knox.token.user.limit.exceeded.action = REMOVE_OLDEST
in thehomepage
topology for theKNOXTOKEN
servicetoken 1
on the Token Generation pagetoken 2
successfully (and the previously created one got revoked):