Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNOX-2730 - Fix missing Correlation id in audit logs #558

Merged
merged 1 commit into from Apr 15, 2022

Conversation

moresandeep
Copy link
Contributor

What changes were proposed in this pull request?

There was a change a while ago due to which correlation id in audit logs was missing in the last audit message for a request. This PR fixes that issue.

How was this patch tested?

This patch was tested locally on local Knox instance.

Before Patch

22/04/14 02:17:24 ||6bb6e07e-1540-47e9-9e07-7798563fe125|audit|[0:0:0:0:0:0:0:1]|WEATHER||||access|uri|/gateway/sandbox/weather/data/2.5/forecast?id=524901&APPID=54557732afcfe106bfc955b9da04fb14|unavailable|Request method: GET
22/04/14 02:17:24 ||6bb6e07e-1540-47e9-9e07-7798563fe125|audit|[0:0:0:0:0:0:0:1]|WEATHER|guest|||authentication|uri|/gateway/sandbox/weather/data/2.5/forecast?id=524901&APPID=54557732afcfe106bfc955b9da04fb14|success|
22/04/14 02:17:24 ||6bb6e07e-1540-47e9-9e07-7798563fe125|audit|[0:0:0:0:0:0:0:1]|WEATHER|guest|||authentication|uri|/gateway/sandbox/weather/data/2.5/forecast?id=524901&APPID=54557732afcfe106bfc955b9da04fb14|success|Groups: []
22/04/14 02:17:24 ||6bb6e07e-1540-47e9-9e07-7798563fe125|audit|[0:0:0:0:0:0:0:1]|WEATHER|guest|||identity-mapping|principal|guest|success|Groups: []
22/04/14 02:17:24 ||6bb6e07e-1540-47e9-9e07-7798563fe125|audit|[0:0:0:0:0:0:0:1]|WEATHER|guest|||dispatch|uri|http://api.openweathermap.org:80/data/2.5/forecast?id=524901&APPID=54557732afcfe106bfc955b9da04fb14&user.name=guest|unavailable|Request method: GET
22/04/14 02:17:25 ||6bb6e07e-1540-47e9-9e07-7798563fe125|audit|[0:0:0:0:0:0:0:1]|WEATHER|guest|||dispatch|uri|http://api.openweathermap.org:80/data/2.5/forecast?id=524901&APPID=54557732afcfe106bfc955b9da04fb14&user.name=guest|success|Response status: 200
22/04/14 02:17:25 |||audit|[0:0:0:0:0:0:0:1]|WEATHER|guest|||access|uri|/gateway/sandbox/weather/data/2.5/forecast?id=524901&APPID=54557732afcfe106bfc955b9da04fb14|success|Response status: 200

After Patch

22/04/15 00:31:58 ||3a931834-3751-40f9-a4d7-aa6232e8bde4|audit|[0:0:0:0:0:0:0:1]|WEATHER||||access|uri|/gateway/sandbox/weather/data/2.5/forecast?id=524901&APPID=54557732afcfe106bfc955b9da04fb14|unavailable|Request method: GET
22/04/15 00:31:58 ||3a931834-3751-40f9-a4d7-aa6232e8bde4|audit|[0:0:0:0:0:0:0:1]|WEATHER|guest|||authentication|uri|/gateway/sandbox/weather/data/2.5/forecast?id=524901&APPID=54557732afcfe106bfc955b9da04fb14|success|
22/04/15 00:31:58 ||3a931834-3751-40f9-a4d7-aa6232e8bde4|audit|[0:0:0:0:0:0:0:1]|WEATHER|guest|||authentication|uri|/gateway/sandbox/weather/data/2.5/forecast?id=524901&APPID=54557732afcfe106bfc955b9da04fb14|success|Groups: []
22/04/15 00:31:58 ||3a931834-3751-40f9-a4d7-aa6232e8bde4|audit|[0:0:0:0:0:0:0:1]|WEATHER|guest|||identity-mapping|principal|guest|success|Groups: []
22/04/15 00:31:59 ||3a931834-3751-40f9-a4d7-aa6232e8bde4|audit|[0:0:0:0:0:0:0:1]|WEATHER|guest|||dispatch|uri|http://api.openweathermap.org:80/data/2.5/forecast?id=524901&APPID=54557732afcfe106bfc955b9da04fb14&user.name=guest|unavailable|Request method: GET
22/04/15 00:32:00 ||3a931834-3751-40f9-a4d7-aa6232e8bde4|audit|[0:0:0:0:0:0:0:1]|WEATHER|guest|||dispatch|uri|http://api.openweathermap.org:80/data/2.5/forecast?id=524901&APPID=54557732afcfe106bfc955b9da04fb14&user.name=guest|success|Response status: 200
22/04/15 00:32:00 ||3a931834-3751-40f9-a4d7-aa6232e8bde4|audit|[0:0:0:0:0:0:0:1]|WEATHER|guest|||access|uri|/gateway/sandbox/weather/data/2.5/forecast?id=524901&APPID=54557732afcfe106bfc955b9da04fb14|success|Response status: 200

@moresandeep moresandeep merged commit a7eed67 into apache:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant