KNOX-1789 - Refactor RemoteAliasService to use service loading #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risdenk
commented
Feb 25, 2019
gateway-server/src/main/java/org/apache/knox/gateway/services/CLIGatewayServices.java
Show resolved
Hide resolved
risdenk
commented
Feb 25, 2019
| @@ -15,7 +15,7 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| package org.apache.knox.gateway.security.impl; | |||
| package org.apache.knox.gateway.services.security.impl; | |||
There was a problem hiding this comment.
Moved to match ZookeeperRemoteAliasService class package
risdenk
force-pushed
the
KNOX-1789
branch
2 times, most recently
from
8b4a9c8
to
e2c44e4
Compare
rlevas
approved these changes
Feb 25, 2019
gateway-server/src/main/java/org/apache/knox/gateway/services/CLIGatewayServices.java
Show resolved
Hide resolved
gateway-server/src/main/java/org/apache/knox/gateway/services/DefaultGatewayServices.java
Show resolved
Hide resolved
Signed-off-by: Kevin Risden <krisden@apache.org>
|
Pushed change to update the comment. |
|
@moresandeep @lmccay @pzampino any thoughts on this PR? |
twmarshall
pushed a commit
to twmarshall/knox
that referenced
this pull request
Aug 27, 2019
…oading (apache#59) Change-Id: Iba479948ef20578a8b7fc5cb3718cbfadbcb495f Signed-off-by: Kevin Risden <krisden@apache.org> Signed-off-by: Kevin Risden <krisden@hortonworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The RemoteAliasService should use service loading to ensure make the RemoteAliasService extensible. Moved existing Zookeeper impl to its own class and loaded via service loading.
How was this patch tested?
mvn -T.5C verify -Ppackage,release