New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KNOX-2771 - Log HTTP client config parameters such as socket timeouts with info level #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UG to INFO and added HTTP client retry count and retry non safe request parameter INFO level logs
zeroflag
reviewed
Jul 6, 2022
gateway-spi/src/main/java/org/apache/knox/gateway/SpiGatewayMessages.java
Outdated
Show resolved
Hide resolved
smolnar82
requested changes
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only small changes are required.
gateway-spi/src/main/java/org/apache/knox/gateway/SpiGatewayMessages.java
Outdated
Show resolved
Hide resolved
gateway-spi/src/main/java/org/apache/knox/gateway/SpiGatewayMessages.java
Outdated
Show resolved
Hide resolved
gateway-spi/src/main/java/org/apache/knox/gateway/SpiGatewayMessages.java
Outdated
Show resolved
Hide resolved
gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/DefaultHttpClientFactory.java
Outdated
Show resolved
Hide resolved
… logs so that the default value is also logged
zeroflag
approved these changes
Jul 6, 2022
smolnar82
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Changed log level of http connection timeout and socket timeout to from DEBUG to INFO and added INFO level log for retry count and retry non safe request parameters, because sometimes clients were confused why the timeout parameters haven't changed even though they changed it in gateway-site.xml, but service.xml override-s it. Now they can see in the log what is the value of these parameters, only after the first request after topology deployment.
How was this patch tested?
I tested it manually, using
curl -k -u tom:tom-password https://localhost:8443/gateway/sandbox/hive
command from terminal.We can see that service.xml overrides gateway-site.xml settings.
The logs only appear after the first request after the topology is deployed.
After that it is not logged until the topology is deployed again.