-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KNOX-2835 SQL DB based topology monitor #670
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroflag
requested review from
moresandeep,
smolnar82 and
pzampino
and removed request for
moresandeep
November 9, 2022 09:29
smolnar82
requested changes
Nov 9, 2022
.../main/java/org/apache/knox/gateway/topology/monitor/DefaultConfigurationMonitorProvider.java
Outdated
Show resolved
Hide resolved
...y-spi/src/main/java/org/apache/knox/gateway/topology/monitor/RemoteConfigurationMonitor.java
Show resolved
Hide resolved
.../main/java/org/apache/knox/gateway/topology/monitor/DefaultConfigurationMonitorProvider.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/knox/gateway/topology/monitor/db/DbRemoteConfigurationMonitor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/knox/gateway/topology/monitor/db/DbRemoteConfigurationMonitor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/knox/gateway/topology/monitor/db/DbRemoteConfigurationMonitor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/knox/gateway/topology/monitor/db/DbRemoteConfigurationMonitor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/knox/gateway/topology/monitor/db/DbRemoteConfigurationMonitor.java
Outdated
Show resolved
Hide resolved
smolnar82
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a similar implementation as the existing zookeeper based monitor, but it uses the SQL DB. Zookeeper is not always available and the DB is already used by the token state service.
The purpose of this monitor is to periodically check the DB for shared-providers and descriptors and update the local file system with the changes from the DB.
The provider logic is implementeed in DbRemoteConfigurationMonitor.
The original DefaultRemoteConfigurationMonitor was renamed to ZkRemoteConfigurationMonitor.
Since the original zookeeper based monitor was already hooked in the Admin UI and Admin API, the new implementation also supports both the UI + API.
How was this patch tested?
gateway-site.xml
Creating provider with curl:
Checking the DB:
Checking the local FS:
Creating descriptor with curl:
Checking the DB:
Checking the local FS:
Deleting provider with curl:
$ curl -X DELETE -H "Content-Type: application/json" -v -k -u admin:admin-password https://localhost:8443/gateway/admin/api/v1/providerconfig/newprov.json
Checking the DB and FS:
Deleting descriptor with curl:
$ curl -X DELETE -H "Content-Type: application/json" -v -k -u admin:admin-password https://localhost:8443/gateway/admin/api/v1/descriptors/newdesc.json
Checking the DB and FS:
Repeated the same tests using the Admin UI.