Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNOX-2940 - knoxcli create-alias/create-aliases command doesn't support values starting with dash #778

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

zeroflag
Copy link
Contributor

What changes were proposed in this pull request?

Modified a check for the create-alias/create-aliases commands to support values with leading dash.

How was this patch tested?

missing value:

 bin/knoxcli.sh  create-alias a1 --value

value with dashes

bin/knoxcli.sh  create-alias a1 --value ---content---

Incorrect usage

bin/knoxcli.sh  create-alias a1 --value --generate
bin/knoxcli.sh  create-alias a1 --value --cluster

Batch alias with dashes

bin/knoxcli.sh  create-aliases --alias --a1-- --value v1 --alias a2 --value --v2--

Batch alias missing value

bin/knoxcli.sh  create-aliases --alias --a1-- --value

Batch alias incorrect usage

bin/knoxcli.sh  create-aliases --alias --a1-- --value --generate
bin/knoxcli.sh  create-aliases --alias --a1-- --value --cluster

@zeroflag zeroflag self-assigned this Jul 21, 2023
Copy link
Contributor

@smolnar82 smolnar82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeroflag zeroflag merged commit 6eac567 into apache:master Jul 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants