18098: KUDU-3197 [tserver] optimal Schema's memory used, using std::s… #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 4, 2022 20:07
…hared_ptr, fix ilint, iwyu, styles
shenxingwuying
commented
Jan 6, 2022
| @@ -191,8 +191,8 @@ class MergeIterState : public boost::intrusive::list_base_hook<> { | |||
| } | |||
|
|
|||
| // Returns the schema from the underlying iterator. | |||
| const Schema& schema() const { | |||
| return DCHECK_NOTNULL(iwb_.iter)->schema(); | |||
There was a problem hiding this comment.
我自提一个。 这个接口是不是不需要变化？
| @@ -57,7 +57,7 @@ class IteratorBase { | |||
| virtual std::string ToString() const = 0; | |||
|
|
|||
| // Return the schema for the rows which this iterator produces. | |||
| virtual const Schema &schema() const = 0; | |||
There was a problem hiding this comment.
我自己提一个。 这个接口或许保持即可。
当前schema的保持，应该new Iterator是有 options。
用它保持，应该可以的。
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create the pr, just for code-review