Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outdated result in type command for expired keys #1286

Merged
merged 4 commits into from Feb 28, 2023
Merged

Fix outdated result in type command for expired keys #1286

merged 4 commits into from Feb 28, 2023

Conversation

jjz921024
Copy link
Contributor

  1. fix For the expired key, the TYPE command returns dirty data #1278
  2. For compatibility with the redis command format, the type command should return simpleString instead of bulkString

@git-hulk git-hulk requested review from PragmaTwice and git-hulk and removed request for PragmaTwice February 28, 2023 04:28
git-hulk
git-hulk reviewed Feb 28, 2023
View reviewed changes
src/storage/redis_db.cc Outdated Show resolved Hide resolved
@jjz921024 @git-hulk
Update src/storage/redis_db.cc
d51eb2e 
Co-authored-by: hulk <hulk.website@gmail.com>
git-hulk
git-hulk approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@PragmaTwice PragmaTwice changed the title Fix type command bug Fix type command for expired keys Feb 28, 2023
@PragmaTwice PragmaTwice changed the title Fix type command for expired keys Fix outdated result in type command for expired keys Feb 28, 2023
@PragmaTwice PragmaTwice merged commit 3cea045 into apache:unstable Feb 28, 2023
@PragmaTwice
Copy link
Member

@jjz921024 Merged. Thanks for your contribution again!

@jjz921024 jjz921024 deleted the my-unstable branch April 20, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@torwig torwig torwig approved these changes

@PragmaTwice PragmaTwice PragmaTwice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

For the expired key, the TYPE command returns dirty data
4 participants
@jjz921024 @PragmaTwice @git-hulk @torwig