Bitmap: Extract common bit operations like GetBit and SetBitTo #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragmaTwice
reviewed
Feb 18, 2024
src/common/bitutil.h
Outdated
| @@ -0,0 +1,148 @@ | |||
| /* | |||
There was a problem hiding this comment.
To keep consistence with other files, could you rename this file to bit_util.h?
|
git-hulk
approved these changes
Feb 19, 2024
PragmaTwice
approved these changes
Feb 19, 2024
JoverZhang
pushed a commit
to JoverZhang/kvrocks
that referenced
this pull request
Feb 24, 2024
…e#2105) This is a refactor, see: apache#2076 Previously, adhoc bit operations are used. This patch extract `GetBit` and `SetBitTo` operation to simplify the impl. Also, because the LSB/MSB format we're using it different in BitmapString and Bitmap( see apache/kvrocks-website#198 ), `lsb` and `msb` is extracted to prevent from mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor, see: #2076
Previously, adhoc bit operations are used. This patch extract
GetBitandSetBitTooperation to simplify the impl.Also, because the LSB/MSB format we're using it different in BitmapString and Bitmap( see apache/kvrocks-website#198 ),
lsbandmsbis extracted to prevent from mistakes.