Bit: Minor refactor BitOp #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapleFU
commented
Feb 21, 2024
| @@ -491,46 +502,29 @@ rocksdb::Status Bitmap::BitOp(BitOpFlags op_flag, const std::string &op_name, co | |||
| lp[i] = reinterpret_cast<const uint64_t *>(fragments[i].data()); | |||
| } | |||
| memcpy(frag_res.get(), fragments[0].data(), frag_minlen); | |||
|
|
|||
| if (op_flag == kBitOpAnd) { | |||
| auto apply_fast_path_op = [&](auto op) { | |||
There was a problem hiding this comment.
Maybe auto vectorize can help avoid this code, however we might not enable it
PragmaTwice
approved these changes
Feb 21, 2024
|
git-hulk
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BitOp uses some c code style: It declare variables when first used, and don't have any comment.
This patch simplify the code and add some comments. It also uses
rocksdb::PinnableSlicerather than std::string for performance.