Minor, make query response with "Unknown error" if exception without …

…message occurs
apache · May 27, 2018 · 2b1e9f4 · 2b1e9f4
1 parent 398401f
commit 2b1e9f4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/query/src/main/java/org/apache/kylin/query/util/QueryUtil.java b/query/src/main/java/org/apache/kylin/query/util/QueryUtil.java
@@ -123,6 +123,9 @@ public static String makeErrorMsgUserFriendly(Throwable e) {
     }
 
     public static String makeErrorMsgUserFriendly(String errorMsg) {
+        if (errorMsg == null) {
+            return "Unknown error.";
+        }
         try {
             // make one line
             errorMsg = errorMsg.replaceAll("\\s", " ");

diff --git a/query/src/test/java/org/apache/kylin/query/util/QueryUtilTest.java b/query/src/test/java/org/apache/kylin/query/util/QueryUtilTest.java
@@ -225,4 +225,10 @@ public void testRemoveCommentInSql() {
             Assert.assertEquals(originSql, QueryUtil.removeCommentInSql(sqlWithComment));
         }
     }
+
+    @Test
+    public void testUnknownErrorResponseMessage() {
+        String msg = QueryUtil.makeErrorMsgUserFriendly(new NullPointerException());
+        Assert.assertEquals("Unknown error.", msg);
+    }
 }