KYLIN-2368 Enable Findbugs plugin

apache · Jan 9, 2017 · 75625ae · 75625ae
1 parent 6f8cdeb
commit 75625ae
Show file tree

Hide file tree

Showing 20 changed files with 92 additions and 87 deletions.
diff --git a/atopcalcite/pom.xml b/atopcalcite/pom.xml
@@ -24,16 +24,14 @@
     <artifactId>atopcalcite</artifactId>
     <packaging>jar</packaging>
     <name>Apache Kylin - Calcite Overrides</name>
+    <description>Apache Kylin - Calcite Overrides</description>
 
     <parent>
         <groupId>org.apache.kylin</groupId>
         <artifactId>kylin</artifactId>
         <version>2.0.0-SNAPSHOT</version>
     </parent>
 
-    <properties>
-    </properties>
-
     <dependencies>
         <dependency>
             <groupId>org.apache.calcite</groupId>

diff --git a/core-common/pom.xml b/core-common/pom.xml
@@ -24,17 +24,14 @@
     <artifactId>kylin-core-common</artifactId>
     <packaging>jar</packaging>
     <name>Apache Kylin - Core Common</name>
+    <description>Apache Kylin - Core Common</description>
 
     <parent>
         <groupId>org.apache.kylin</groupId>
         <artifactId>kylin</artifactId>
         <version>2.0.0-SNAPSHOT</version>
-
     </parent>
 
-    <properties>
-    </properties>
-
     <dependencies>
         <!-- Basic Utilities -->
         <dependency>

diff --git a/core-cube/pom.xml b/core-cube/pom.xml
@@ -24,12 +24,12 @@
     <artifactId>kylin-core-cube</artifactId>
     <packaging>jar</packaging>
     <name>Apache Kylin - Core Cube</name>
+    <description>Apache Kylin - Core Cube</description>
 
     <parent>
         <groupId>org.apache.kylin</groupId>
         <artifactId>kylin</artifactId>
         <version>2.0.0-SNAPSHOT</version>
-
     </parent>
 
     <dependencies>

diff --git a/core-dictionary/pom.xml b/core-dictionary/pom.xml
@@ -24,17 +24,14 @@
     <artifactId>kylin-core-dictionary</artifactId>
     <packaging>jar</packaging>
     <name>Apache Kylin - Core Dictionary</name>
+    <description>Apache Kylin - Core Dictionary</description>
 
     <parent>
         <groupId>org.apache.kylin</groupId>
         <artifactId>kylin</artifactId>
         <version>2.0.0-SNAPSHOT</version>
-
     </parent>
 
-    <properties>
-    </properties>
-
     <dependencies>
 
         <dependency>

diff --git a/core-job/pom.xml b/core-job/pom.xml
@@ -24,17 +24,14 @@
     <artifactId>kylin-core-job</artifactId>
     <packaging>jar</packaging>
     <name>Apache Kylin - Core Job</name>
+    <description>Apache Kylin - Core Job</description>
 
     <parent>
         <groupId>org.apache.kylin</groupId>
         <artifactId>kylin</artifactId>
         <version>2.0.0-SNAPSHOT</version>
-
     </parent>
 
-    <properties>
-    </properties>
-
     <dependencies>
 
         <dependency>

diff --git a/core-metadata/pom.xml b/core-metadata/pom.xml
@@ -24,17 +24,14 @@
     <artifactId>kylin-core-metadata</artifactId>
     <packaging>jar</packaging>
     <name>Apache Kylin - Core Metadata</name>
+    <description>Apache Kylin - Core Metadata</description>
 
     <parent>
         <groupId>org.apache.kylin</groupId>
         <artifactId>kylin</artifactId>
         <version>2.0.0-SNAPSHOT</version>
-
     </parent>
 
-    <properties>
-    </properties>
-
     <dependencies>
 
         <dependency>

diff --git a/core-storage/pom.xml b/core-storage/pom.xml
@@ -24,17 +24,14 @@
     <artifactId>kylin-core-storage</artifactId>
     <packaging>jar</packaging>
     <name>Apache Kylin - Core Storage</name>
+    <description>Apache Kylin - Core Storage</description>
 
     <parent>
         <groupId>org.apache.kylin</groupId>
         <artifactId>kylin</artifactId>
         <version>2.0.0-SNAPSHOT</version>
-
     </parent>
 
-    <properties>
-    </properties>
-
     <dependencies>
 
         <dependency>

diff --git a/engine-mr/pom.xml b/engine-mr/pom.xml
@@ -24,19 +24,15 @@
     <artifactId>kylin-engine-mr</artifactId>
     <packaging>jar</packaging>
     <name>Apache Kylin - MapReduce Engine</name>
+    <description>Apache Kylin - MapReduce Engine</description>
 
     <parent>
         <groupId>org.apache.kylin</groupId>
         <artifactId>kylin</artifactId>
         <version>2.0.0-SNAPSHOT</version>
-
     </parent>
 
-    <properties>
-    </properties>
-
     <dependencies>
-
         <dependency>
             <groupId>org.apache.kylin</groupId>
             <artifactId>kylin-core-common</artifactId>

diff --git a/engine-spark/pom.xml b/engine-spark/pom.xml
@@ -20,22 +20,18 @@
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
+
+    <artifactId>kylin-engine-spark</artifactId>
+    <packaging>jar</packaging>
+    <name>Apache Kylin - Spark Engine</name>
+    <description>Apache Kylin - Spark Engine</description>
+
     <parent>
         <groupId>org.apache.kylin</groupId>
         <artifactId>kylin</artifactId>
         <version>2.0.0-SNAPSHOT</version>
-
     </parent>
 
-    <artifactId>kylin-engine-spark</artifactId>
-
-    <name>Apache Kylin - Spark Engine</name>
-    <url>http://maven.apache.org</url>
-    <properties>
-        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-    </properties>
-
-
     <dependencies>
         <dependency>
             <groupId>org.apache.kylin</groupId>

diff --git a/jdbc/pom.xml b/jdbc/pom.xml
@@ -20,6 +20,7 @@
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
+
     <artifactId>kylin-jdbc</artifactId>
     <packaging>jar</packaging>
     <name>Apache Kylin - JDBC Driver</name>
@@ -29,11 +30,9 @@
         <groupId>org.apache.kylin</groupId>
         <artifactId>kylin</artifactId>
         <version>2.0.0-SNAPSHOT</version>
-
     </parent>
 
     <properties>
-        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <shadeBase>org.apache.kylin.jdbc.shaded</shadeBase>
     </properties>
 

diff --git a/kylin-it/pom.xml b/kylin-it/pom.xml
@@ -20,15 +20,18 @@
 
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <artifactId>kylin-it</artifactId>
+    <packaging>jar</packaging>
+    <name>Apache Kylin - Integration Test</name>
+    <description>Apache Kylin - Integration Test</description>
+
     <parent>
         <artifactId>kylin</artifactId>
         <groupId>org.apache.kylin</groupId>
         <version>2.0.0-SNAPSHOT</version>
     </parent>
-    <modelVersion>4.0.0</modelVersion>
-
-    <artifactId>kylin-it</artifactId>
-    <name>Apache Kylin - Integration Test</name>
 
     <properties>
         <hdp.version/>

diff --git a/pom.xml b/pom.xml
@@ -93,7 +93,6 @@
         <jsch.version>0.1.53</jsch.version>
         <xerces.version>2.11.0</xerces.version>
         <xalan.version>2.7.2</xalan.version>
-        <!--<compress-lzf.version>1.0.3</compress-lzf.version>-->
         <extendedset.version>1.3.4</extendedset.version>
         <kryo.version>4.0.0</kryo.version>
         <ehcache.version>2.10.2.2.21</ehcache.version>
@@ -622,13 +621,6 @@
                 <artifactId>xalan</artifactId>
                 <version>${xalan.version}</version>
             </dependency>
-            <!--
-            <dependency>
-                <groupId>com.ning</groupId>
-                <artifactId>compress-lzf</artifactId>
-                <version>${compress-lzf.version}</version>
-            </dependency>
-            -->
             <dependency>
                 <groupId>com.n3twork.druid</groupId>
                 <artifactId>extendedset</artifactId>
@@ -901,19 +893,6 @@
                         <includePom>true</includePom>
                     </configuration>
                 </plugin>
-                <!--<plugin>-->
-                <!--<groupId>org.apache.maven.plugins</groupId>-->
-                <!--<artifactId>maven-failsafe-plugin</artifactId>-->
-                <!--<version>2.6</version>-->
-                <!--<executions>-->
-                <!--<execution>-->
-                <!--<goals>-->
-                <!--<goal>integration-test</goal>-->
-                <!--<goal>verify</goal>-->
-                <!--</goals>-->
-                <!--</execution>-->
-                <!--</executions>-->
-                <!--</plugin>-->
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-release-plugin</artifactId>
@@ -945,6 +924,17 @@
                         </execution>
                     </executions>
                 </plugin>
+                <plugin>
+                    <groupId>org.codehaus.mojo</groupId>
+                    <artifactId>findbugs-maven-plugin</artifactId>
+                    <version>3.0.4</version>
+                    <configuration>
+                        <xmlOutput>true</xmlOutput>
+                        <effort>Max</effort>
+                        <threshold>Low</threshold>
+                        <failOnError>false</failOnError>
+                    </configuration>
+                </plugin>
                 <plugin>
                     <groupId>net.ju-n.maven.plugins</groupId>
                     <artifactId>checksum-maven-plugin</artifactId>
@@ -998,6 +988,10 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
             </plugin>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>findbugs-maven-plugin</artifactId>
+            </plugin>
         </plugins>
     </build>
 
@@ -1024,6 +1018,43 @@
         <module>tomcat-ext</module>
     </modules>
 
+    <reporting>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-project-info-reports-plugin</artifactId>
+                <version>2.9</version>
+                <reportSets>
+                    <reportSet>
+                        <reports>
+                            <report>index</report>
+                            <report>summary</report>
+                            <report>dependency-info</report>
+                            <report>project-team</report>
+                            <report>scm</report>
+                            <report>issue-tracking</report>
+                            <report>mailing-list</report>
+                            <!-- <report>dependency-management</report> -->
+                            <!-- <report>dependencies</report> -->
+                            <!-- <report>dependency-convergence</report> -->
+                            <report>cim</report>
+                            <report>plugin-management</report>
+                            <report>plugins</report>
+                            <report>distribution-management</report>
+                            <report>license</report>
+                            <report>modules</report>
+                        </reports>
+                    </reportSet>
+                </reportSets>
+            </plugin>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>findbugs-maven-plugin</artifactId>
+                <version>3.0.4</version>
+            </plugin>
+        </plugins>
+    </reporting>
+
     <profiles>
         <profile>
             <id>sandbox</id>

diff --git a/query/pom.xml b/query/pom.xml
@@ -20,6 +20,7 @@
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
+
     <artifactId>kylin-query</artifactId>
     <packaging>jar</packaging>
     <name>Apache Kylin - Query</name>

diff --git a/server-base/pom.xml b/server-base/pom.xml
@@ -24,17 +24,14 @@
     <artifactId>kylin-server-base</artifactId>
     <packaging>jar</packaging>
     <name>Apache Kylin - REST Server Base</name>
+    <description>Apache Kylin - REST Server Base</description>
 
     <parent>
         <groupId>org.apache.kylin</groupId>
         <artifactId>kylin</artifactId>
         <version>2.0.0-SNAPSHOT</version>
-
     </parent>
 
-    <properties>
-    </properties>
-
     <dependencies>
         <dependency>
             <groupId>org.apache.kylin</groupId>

diff --git a/server/pom.xml b/server/pom.xml
@@ -24,7 +24,7 @@
     <artifactId>kylin-server</artifactId>
     <packaging>war</packaging>
     <name>Apache Kylin - REST Server</name>
-    <description>Kylin REST Service and RPC Server.</description>
+    <description>Kylin REST Service and RPC Server</description>
 
     <parent>
         <groupId>org.apache.kylin</groupId>

diff --git a/source-hive/pom.xml b/source-hive/pom.xml
@@ -24,17 +24,14 @@
     <artifactId>kylin-source-hive</artifactId>
     <packaging>jar</packaging>
     <name>Apache Kylin - Hive Source</name>
+    <description>Apache Kylin - Hive Source</description>
 
     <parent>
         <groupId>org.apache.kylin</groupId>
         <artifactId>kylin</artifactId>
         <version>2.0.0-SNAPSHOT</version>
-
     </parent>
 
-    <properties>
-    </properties>
-
     <dependencies>
 
         <dependency>