KYLIN-3929 Check satisfaction before execute cubeplanner algorithm

apache · Apr 3, 2019 · 80c63f5 · 80c63f5
1 parent 0daf07c
commit 80c63f5
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidRecommender.java b/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidRecommender.java
@@ -128,6 +128,10 @@ public Map<Long, Long> getRecommendCuboidList(CuboidStats cuboidStats, KylinConf
         int allCuboidCount = cuboidStats.getAllCuboidsForMandatory().size()
                 + cuboidStats.getAllCuboidsForSelection().size();
 
+        if (!ifForceRecommend && allCuboidCount <= threshold1) {
+            return null;
+        }
+
         BenefitPolicy benefitPolicy = new PBPUSCalculator(cuboidStats);
         CuboidRecommendAlgorithm algorithm = null;
 
@@ -157,9 +161,6 @@ public Map<Long, Long> getRecommendCuboidList(CuboidStats cuboidStats, KylinConf
             }
         }
 
-        if (!ifForceRecommend && allCuboidCount <= threshold1) {
-            return null;
-        }
         return recommendCuboidsWithStats;
     }