KYLIN-4933 Support set cache strength for dict cache

apache · Apr 6, 2021 · ca08012 · ca08012
1 parent 25b8a88
commit ca08012
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java b/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
@@ -2709,4 +2709,7 @@ public int getDistCPMaxMapNum(){
         return Integer.valueOf(getOptional("kylin.storage.distcp-max-map-num", "50"));
     }
 
+    public String getKylinDictCacheStrength(){
+        return getOptional("kylin.dict.cache.strength", "soft");
+    };
 }
diff --git a/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryManager.java b/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryManager.java
@@ -67,8 +67,20 @@ static DictionaryManager newInstance(KylinConfig config) throws IOException {
 
     private DictionaryManager(KylinConfig config) {
         this.config = config;
-        this.dictCache = CacheBuilder.newBuilder()//
-                .softValues()//
+        CacheStrength strength = CacheStrength.valueOf(config.getKylinDictCacheStrength());
+        CacheBuilder cacheBuilder = CacheBuilder.newBuilder();
+        switch (strength) {
+            case soft:
+                cacheBuilder.softValues();
+                break;
+            case week:
+                cacheBuilder.weakValues();
+                break;
+            case strong:
+            default:
+                break;
+        }
+        this.dictCache = cacheBuilder//
                 .removalListener(new RemovalListener<String, DictionaryInfo>() {
                     @Override
                     public void onRemoval(RemovalNotification<String, DictionaryInfo> notification) {
@@ -450,4 +462,7 @@ private ResourceStore getStore() {
         return ResourceStore.getStore(config);
     }
 
+    private enum CacheStrength{
+        week, soft, strong
+    }
 }