Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4334 Auto discard all jobs while disable the Real Time Cube #1051

Merged
merged 1 commit into from Feb 4, 2020

Conversation

wangxiaojing123
Copy link

@codecov-io
Copy link

Codecov Report

Merging #1051 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1051      +/-   ##
============================================
- Coverage        25%   24.99%   -0.02%     
+ Complexity     6180     6179       -1     
============================================
  Files          1438     1438              
  Lines         87669    87680      +11     
  Branches      12256    12258       +2     
============================================
- Hits          21926    21915      -11     
- Misses        63593    63612      +19     
- Partials       2150     2153       +3
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/kylin/rest/service/CubeService.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ream/core/storage/columnar/ColumnarStoreCache.java 52.27% <0%> (-3.41%) 8% <0%> (ø)
...che/kylin/stream/core/storage/CheckPointStore.java 63.63% <0%> (-3.04%) 21% <0%> (-1%)
...he/kylin/job/impl/threadpool/DefaultScheduler.java 74.41% <0%> (-2.33%) 12% <0%> (ø)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.3% <0%> (-0.92%) 7% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3777021...bd951eb. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5500

  • 0 of 11 (0.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-2.0e**-05%**) to 27.453%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java 2 80.23%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java 2 73.74%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 4 77.81%
Totals Coverage Status
Change from base Build 5496: -2.0e-05%
Covered Lines: 24071
Relevant Lines: 87680

💛 - Coveralls

@hit-lacus hit-lacus self-requested a review February 3, 2020 09:28
@hit-lacus
Copy link
Member

I have tested it, it works well, let's merge it.

@hit-lacus hit-lacus merged commit 2a68874 into apache:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants