Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4372 Fix bug of delete file too later cause ZK started by HBase… #1103

Merged
merged 1 commit into from Feb 14, 2020

Conversation

weibin0516
Copy link

… crash

@codecov-io
Copy link

Codecov Report

Merging #1103 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1103      +/-   ##
============================================
+ Coverage     25.05%   25.06%   +0.01%     
- Complexity     6224     6225       +1     
============================================
  Files          1440     1440              
  Lines         87819    87883      +64     
  Branches      12275    12291      +16     
============================================
+ Hits          22001    22031      +30     
- Misses        63660    63694      +34     
  Partials       2158     2158
Impacted Files Coverage Δ Complexity Δ
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 72.97% <0%> (-5.41%) 6% <0%> (-1%)
...in/java/org/apache/kylin/query/util/QueryUtil.java 62.24% <0%> (-0.65%) 26% <0%> (ø)
...va/org/apache/kylin/query/routing/QueryRouter.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...va/org/apache/kylin/rest/service/QueryService.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ava/org/apache/kylin/rest/service/CubeService.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ylin/rest/controller/ExternalFilterController.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...org/apache/kylin/common/debug/BackdoorToggles.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...lin/job/impl/threadpool/PriorityFetcherRunner.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...rg/apache/kylin/rest/controller/JobController.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...cube/v2/coprocessor/endpoint/CubeVisitService.java 67.75% <0%> (ø) 16% <0%> (ø) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 147109e...6077eae. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5609

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 27.528%

Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 3 78.42%
Totals Coverage Status
Change from base Build 5602: 0.006%
Covered Lines: 24192
Relevant Lines: 87883

💛 - Coveralls

Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nichunen nichunen merged commit fa3862a into apache:master Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants