Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4307 WritrConflictException when build cube by layer #1107

Merged
merged 1 commit into from Feb 18, 2020

Conversation

zhangayqian
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Feb 13, 2020

Pull Request Test Coverage Report for Build 5635

  • 6 of 12 (50.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 27.496%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java 6 12 50.0%
Files with Coverage Reduction New Missed Lines %
core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java 1 81.08%
core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java 2 28.15%
Totals Coverage Status
Change from base Build 5634: 0.002%
Covered Lines: 24193
Relevant Lines: 87986

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Feb 14, 2020

Codecov Report

Merging #1107 into master will decrease coverage by 0.02%.
The diff coverage is 41.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1107      +/-   ##
============================================
- Coverage     25.06%   25.03%   -0.03%     
- Complexity     6224     6225       +1     
============================================
  Files          1440     1440              
  Lines         87882    87986     +104     
  Branches      12291    12311      +20     
============================================
+ Hits          22026    22029       +3     
- Misses        63696    63796     +100     
- Partials       2160     2161       +1
Impacted Files Coverage Δ Complexity Δ
...n/java/org/apache/kylin/job/dao/ExecutableDao.java 26.47% <41.66%> (-1.05%) 24 <2> (ø)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.3% <0%> (-0.92%) 7% <0%> (ø)
...c/main/java/org/apache/kylin/cube/CubeSegment.java 48.93% <0%> (-0.41%) 65% <0%> (+1%)
...ain/java/org/apache/kylin/engine/mr/CubingJob.java 1.56% <0%> (-0.32%) 2% <0%> (ø)
.../java/org/apache/kylin/common/KylinConfigBase.java 12.32% <0%> (-0.02%) 44% <0%> (ø)
.../engine/mr/steps/UpdateCubeInfoAfterBuildStep.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...apache/kylin/engine/mr/common/CubeStatsReader.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../engine/mr/steps/UpdateCubeInfoAfterMergeStep.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...c/main/java/org/apache/kylin/cube/CubeManager.java 36.59% <0%> (+0.1%) 44% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed32209...1aeb680. Read the comment docs.

@zhangayqian zhangayqian force-pushed the KYLIN-4307 branch 6 times, most recently from 40ad773 to c2dd80b Compare February 18, 2020 05:16
Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nichunen nichunen merged commit 78deee8 into apache:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants