Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3293, fix FixedLenHexDimEnc.java return a wrong code length lea… #117

Closed
wants to merge 1 commit into from

Conversation

Aaaaaaron
Copy link
Member

…ds to cut bytes error.

@asfgit
Copy link

asfgit commented Mar 16, 2018

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #117 into master will increase coverage by <.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #117      +/-   ##
============================================
+ Coverage     21.85%   21.85%   +<.01%     
- Complexity     3884     3889       +5     
============================================
  Files           996      996              
  Lines         59999    59999              
  Branches       8666     8666              
============================================
+ Hits          13112    13114       +2     
+ Misses        45667    45664       -3     
- Partials       1220     1221       +1
Impacted Files Coverage Δ Complexity Δ
.../org/apache/kylin/dimension/FixedLenHexDimEnc.java 83.46% <55.55%> (ø) 23 <6> (+1) ⬆️
...rg/apache/kylin/storage/hbase/HBaseConnection.java 13.08% <0%> (-4.72%) 6% <0%> (ø)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.3% <0%> (-0.92%) 7% <0%> (ø)
.../java/org/apache/kylin/common/KylinConfigBase.java 16.18% <0%> (+1.22%) 37% <0%> (+2%) ⬆️
...g/apache/kylin/source/datagen/ColumnGenerator.java 72.29% <0%> (+1.35%) 8% <0%> (ø) ⬇️
...main/java/org/apache/kylin/common/KylinConfig.java 32.35% <0%> (+1.68%) 21% <0%> (+1%) ⬆️
...e/kylin/common/KylinConfigCannotInitException.java 100% <0%> (+100%) 1% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf6d76d...1d2d804. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3049

  • 6 of 9 (66.67%) changed or added relevant lines in 1 file are covered.
  • 15 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.005%) to 23.895%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-metadata/src/main/java/org/apache/kylin/dimension/FixedLenHexDimEnc.java 6 9 66.67%
Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
storage-hbase/src/main/java/org/apache/kylin/storage/hbase/HBaseConnection.java 10 17.28%
Totals Coverage Status
Change from base Build 3046: 0.005%
Covered Lines: 14337
Relevant Lines: 59999

💛 - Coveralls

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see there are only two places to write to "hexLength": one is in the construction method, and the other is in the readExternal() method. The bug is in readExternal(), which doesn't update 'bytelen'. Just add one line there can fix the problem.

@Aaaaaaron Aaaaaaron closed this Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants