Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4437 repalce deprecated mapred.job.name & set cube in hive mr … #1170

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

zhoukangcn
Copy link

@zhoukangcn zhoukangcn commented Mar 28, 2020

…name

Proposed changes

see: https://issues.apache.org/jira/browse/KYLIN-4437
mapred.job.name is deprecated. Change to mapreduce.job.name is better.

add cube name and job id in MR job name, could help admins to find the job in yarn cluster.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

@codecov-io
Copy link

Codecov Report

Merging #1170 into master will decrease coverage by 0.03%.
The diff coverage is 12.01%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1170      +/-   ##
============================================
- Coverage     25.04%   25.01%   -0.04%     
- Complexity     6247     6251       +4     
============================================
  Files          1446     1449       +3     
  Lines         88314    88492     +178     
  Branches      12358    12372      +14     
============================================
+ Hits          22121    22135      +14     
- Misses        64018    64181     +163     
- Partials       2175     2176       +1     
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/kylin/common/KylinConfigBase.java 12.26% <0.00%> (ø) 44.00 <0.00> (ø)
.../java/org/apache/kylin/common/util/HadoopUtil.java 14.56% <ø> (ø) 10.00 <0.00> (ø)
...in/java/org/apache/kylin/common/util/ToolUtil.java 10.63% <ø> (+1.54%) 2.00 <0.00> (ø)
...ain/java/org/apache/kylin/engine/mr/CubingJob.java 1.53% <0.00%> (-0.04%) 2.00 <0.00> (ø)
...che/kylin/engine/mr/steps/CreateDictionaryJob.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/org/apache/kylin/rest/service/CubeService.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rg/apache/kylin/rest/service/DiagnosisService.java 26.78% <0.00%> (ø) 6.00 <0.00> (ø)
...che/kylin/source/hive/CreateFlatHiveTableStep.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...lin/source/hive/RedistributeFlatHiveTableStep.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...n/java/org/apache/kylin/tool/DiagnosisInfoCLI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16a4be...50ef9ec. Read the comment docs.

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@nichunen nichunen merged commit 4836f25 into apache:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants