Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3849 Flink cubing step : convert to HFile #1201

Merged
merged 1 commit into from May 22, 2020

Conversation

harveyyue
Copy link

Proposed changes

Add flink cubing step: convert to HFile

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5888

  • 0 of 197 (0.0%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 27.262%

Changes Missing Coverage Covered Lines Changed/Added Lines %
storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CreateHTableJob.java 0 1 0.0%
storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HBaseFlinkOutputTransition.java 0 2 0.0%
storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HBaseFlinkSteps.java 0 53 0.0%
storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/FlinkCubeHFile.java 0 141 0.0%
Files with Coverage Reduction New Missed Lines %
core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java 2 80.23%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java 2 73.74%
Totals Coverage Status
Change from base Build 5884: -0.06%
Covered Lines: 24347
Relevant Lines: 89306

💛 - Coveralls

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@shaofengshi shaofengshi merged commit 51cb30e into apache:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants