KYLIN-4515 fix error with sending mail on ssl #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is context of this problem：https://www.mail-archive.com/user@kylin.apache.org/msg04009.html When we set `starttlsEnabled` to true, specify a ssl port as 465, emails could not be sent by this ssl port, It still use 25 default port. The root cause is, with such config above, HTMLEmail client doesn't enable ssl connection, so we need to enable ssl connection by `setSSLOnConnect` as well when using ssl port.
Codecov Report
@@ Coverage Diff @@
## master #1214 +/- ##
============================================
- Coverage 24.85% 24.84% -0.01%
+ Complexity 6265 6263 -2
============================================
Files 1453 1453
Lines 89225 89226 +1
Branches 12456 12456
============================================
- Hits 22173 22170 -3
- Misses 64875 64878 +3
- Partials 2177 2178 +1
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 5913
💛 - Coveralls |
|
@chenqingspring Thanks for your pr, would you please open a jira for the issue? |
|
@nichunen Sure, with my pleasure :) KYLIN-4515 |
shaofengshi
requested changes
May 22, 2020
|
@shaofengshi Hi shaofeng, what do you mean by associating github commit? I'm trying to rename this issue start with KYLIN-4515, but it seems not editable. |
chenqingspring
changed the title
|
@shaofengshi somehow ... this issue name could be changed. Tell me if I should do anything else? |
hit-lacus
pushed a commit
to hit-lacus/kylin
that referenced
this pull request
Oct 8, 2020
Here is context of this problem：https://www.mail-archive.com/user@kylin.apache.org/msg04009.html When we set `starttlsEnabled` to true, specify a ssl port as 465, emails could not be sent by this ssl port, It still use 25 default port. The root cause is, with such config above, HTMLEmail client doesn't enable ssl connection, so we need to enable ssl connection by `setSSLOnConnect` as well when using ssl port.
hit-lacus
pushed a commit
that referenced
this pull request
Oct 12, 2020
Here is context of this problem：https://www.mail-archive.com/user@kylin.apache.org/msg04009.html When we set `starttlsEnabled` to true, specify a ssl port as 465, emails could not be sent by this ssl port, It still use 25 default port. The root cause is, with such config above, HTMLEmail client doesn't enable ssl connection, so we need to enable ssl connection by `setSSLOnConnect` as well when using ssl port.
zhangayqian
pushed a commit
to zhangayqian/kylin
that referenced
this pull request
Jun 11, 2021
Here is context of this problem：https://www.mail-archive.com/user@kylin.apache.org/msg04009.html When we set `starttlsEnabled` to true, specify a ssl port as 465, emails could not be sent by this ssl port, It still use 25 default port. The root cause is, with such config above, HTMLEmail client doesn't enable ssl connection, so we need to enable ssl connection by `setSSLOnConnect` as well when using ssl port. (cherry picked from commit d8060b6)
zhangayqian
pushed a commit
to zhangayqian/kylin
that referenced
this pull request
Jun 11, 2021
Here is context of this problem：https://www.mail-archive.com/user@kylin.apache.org/msg04009.html When we set `starttlsEnabled` to true, specify a ssl port as 465, emails could not be sent by this ssl port, It still use 25 default port. The root cause is, with such config above, HTMLEmail client doesn't enable ssl connection, so we need to enable ssl connection by `setSSLOnConnect` as well when using ssl port. (cherry picked from commit d8060b6)
hit-lacus
pushed a commit
that referenced
this pull request
Jun 27, 2021
Here is context of this problem：https://www.mail-archive.com/user@kylin.apache.org/msg04009.html When we set `starttlsEnabled` to true, specify a ssl port as 465, emails could not be sent by this ssl port, It still use 25 default port. The root cause is, with such config above, HTMLEmail client doesn't enable ssl connection, so we need to enable ssl connection by `setSSLOnConnect` as well when using ssl port. (cherry picked from commit d8060b6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Here is context of this problem：https://www.mail-archive.com/user@kylin.apache.org/msg04009.html
When I set
starttlsEnabledto true, and specify a ssl port as 465, the email could not be sent by this ssl port. It still use 25 default port.The root cause is, with such config above, HTMLEmail client doesn't enable ssl connection, so we need to enable ssl connection by
setSSLOnConnectas well when using ssl port.Types of changes
[Bugfix] fix error with sending mail on ssl