KYLIN-2971 Fix the wrong "Realization Names" and missing "Cuboid Ids" in logQuery when hit cache #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5929
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #1215 +/- ##
============================================
- Coverage 24.85% 24.83% -0.03%
+ Complexity 6266 6263 -3
============================================
Files 1453 1453
Lines 89225 89237 +12
Branches 12456 12458 +2
============================================
- Hits 22181 22165 -16
- Misses 64869 64892 +23
- Partials 2175 2180 +5
Continue to review full report at Codecov.
|
… in logQuery when hit cache Problems: 1. The value of "Realization Names" in logQuery is wrong when query two different sqls within the same thread and second sql hits cache: Example: 1). query Q1 hit project P1 and cube C1; 2). query Q2 hit project P2 and cube C2 in the same thread with Q1; 3). Q1 comes again and hits cache, it will show project P1 and cube C2. However, it should be cube C1. 2. Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does not have OLAPContext; Solutions: 1. Call 'OLAPContext.clearThreadLocalContexts()' before a query starts; 2. Get "Cuboid Ids" from SQLResponse when "OLAPContext.getThreadLocalContexts()" is null;
|
LGTM |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems:
The value of "Realization Names" in logQuery is wrong when query two different sqls within the same thread and second sql hits cache:
Example:
1). query Q1 hit project P1 and cube C1;
2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
3). Q1 comes again and hits cache, it will show project P1 and cube C2. However, it should be cube C1.
Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does not have OLAPContext;
Solutions:
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.documentbranchFurther comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...