KYLIN-3698 some enhancement for check-env.sh

[zhangayqian]

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I have create an issue on Kylin's jira, and have described the bug/feature there in detail
• Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
• Compiling and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• If this change need a document change, I will prepare another pr against the document branch
• Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

[zhangayqian]

Evidence:

[codecov-commenter]

Codecov Report

Merging #1222 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1222      +/-   ##
============================================
- Coverage     24.85%   24.84%   -0.01%     
+ Complexity     6266     6264       -2     
============================================
  Files          1453     1453              
  Lines         89225    89225              
  Branches      12456    12456              
============================================
- Hits          22175    22171       -4     
- Misses        64874    64876       +2     
- Partials       2176     2178       +2     

Impacted Files	Coverage Δ	Complexity Δ
...org/apache/kylin/rest/util/QueryRequestLimits.java	35.71% <0.00%> (-4.77%)	5.00% <0.00%> (-1.00%)
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java	63.84% <0.00%> (-2.31%)	0.00% <0.00%> (ø%)
...ream/core/storage/columnar/ColumnarStoreCache.java	50.00% <0.00%> (-2.28%)	7.00% <0.00%> (-1.00%)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java	70.21% <0.00%> (+0.91%)	7.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7886a24...e2e51bb. Read the comment docs.

[coveralls]

Pull Request Test Coverage Report for Build 5921

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 6 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.001%) to 27.293%

---

Files with Coverage Reduction	New Missed Lines	%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java	1	56.82%
core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java	2	68.46%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java	3	78.42%

Totals
Change from base Build 5911:	-0.001%
Covered Lines:	24352
Relevant Lines:	89225

---

💛 - Coveralls

[nichunen]

LGTM

[hit-lacus]

Why should remove these lines?

[zhangayqian]

Because these three checks are put in check-env.sh, there is no need to check them again here.
But now it is found that some tool commands, such as bin/kylin.sh org.apache.kylin.source.kafka.util.KafkaSampleProducer, require Kafka's dependency. However, the check-env.sh is not executed when using this command, which makes it unable to load Kafka's dependency.
This is my negligence. It should not be removed here.