Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade calcite to 1.16.0-kylin-r5 #1242

Merged
merged 1 commit into from Jun 5, 2020

Conversation

zzcclp
Copy link

@zzcclp zzcclp commented Jun 5, 2020

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-commenter
Copy link

Codecov Report

Merging #1242 into master will increase coverage by 0.83%.
The diff coverage is 27.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1242      +/-   ##
============================================
+ Coverage     24.87%   25.71%   +0.83%     
- Complexity     6258     6626     +368     
============================================
  Files          1452     1484      +32     
  Lines         89036    91182    +2146     
  Branches      12437    12725     +288     
============================================
+ Hits          22151    23450    +1299     
- Misses        64709    65430     +721     
- Partials       2176     2302     +126     
Impacted Files Coverage Δ Complexity Δ
...pache/kylin/cache/cachemanager/CacheConstants.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../cachemanager/InstrumentedEhCacheCacheManager.java 57.14% <ø> (ø) 5.00 <0.00> (ø)
.../cachemanager/RemoteLocalFailOverCacheManager.java 78.57% <0.00%> (-6.05%) 7.00 <0.00> (ø)
.../kylin/cache/memcached/MemcachedChunkingCache.java 39.70% <ø> (-0.45%) 15.00 <0.00> (ø)
...apache/kylin/cache/memcached/MemcachedMetrics.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ache/kylin/common/BackwardCompatibilityConfig.java 41.81% <ø> (ø) 15.00 <0.00> (ø)
...main/java/org/apache/kylin/common/KylinConfig.java 40.37% <ø> (ø) 28.00 <0.00> (ø)
...ain/java/org/apache/kylin/common/KylinVersion.java 35.06% <ø> (ø) 11.00 <0.00> (ø)
...ain/java/org/apache/kylin/common/QueryContext.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/org/apache/kylin/common/QueryContextFacade.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 362 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fce51e...dca9d97. Read the comment docs.

@hit-lacus hit-lacus merged commit 5d592b9 into apache:master Jun 5, 2020
@zzcclp zzcclp deleted the upgrade-calcite-r5 branch June 5, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants