Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4355 add ut #1255

Merged
merged 1 commit into from
Jun 14, 2020
Merged

KYLIN-4355 add ut #1255

merged 1 commit into from
Jun 14, 2020

Conversation

hit-lacus
Copy link
Member

@hit-lacus hit-lacus commented Jun 13, 2020

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6013

  • 5 of 11 (45.45%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 28.278%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java 0 1 0.0%
stream-receiver/src/main/java/org/apache/kylin/stream/server/StreamingServer.java 0 1 0.0%
server-base/src/main/java/org/apache/kylin/rest/controller/AdminController.java 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 1 78.12%
server-base/src/main/java/org/apache/kylin/rest/controller/AdminController.java 1 0%
Totals Coverage Status
Change from base Build 6008: 0.03%
Covered Lines: 25790
Relevant Lines: 91202

💛 - Coveralls

@hit-lacus hit-lacus merged commit faa15ad into apache:master Jun 14, 2020
@zhangayqian
Copy link
Contributor

Check list

  • Step 1. [OPTIONAL]Understand background/root cause/design basically(one hour EST) . Its issue type is
    • bug fix
    • new feature
    • enhancement
  • Step 2. Test cases are designed and documented (30 minutes EST).
  • Step 3. Prepare specific env, for example:
    • mock data (maybe some specific data type)
    • test env (maybe install a RDBMS instance).
  • Step 4. Verify and make sure test cases passed.
  • Step 5. Paste manual important steps and screenshots here (20 minutes EST).
    • If you find difficulty in pick most important evidence, please attach diagnosis package.
  • Step 6. Do more check in user perspective (20 minutes EST)
    • Doc need be updated? And if it is updated? Ask help for release manager if so.
    • If it is a breaking change so we should notify Kylin community? Ask help for release manager if so.
  • Step 7. Summarize this test (20 minutes EST).

Total estimate

  • 4 hours for small issue from optimistic estimate.

Note

If you find some unexpected and unrelated error/mistake, please DO report it if it is truly a mistake, I think we may research and fix it in the future.

If you find background information/root cause analysis is not complete or ambiguous, please try to contact to author or do a quick research and record what you find. It is a good chance to learn something interesting.

If you find it is not easy to design testcase, please notify release manager.

@zhangayqian
Copy link
Contributor

Design test case

Prepare test env

  • Start one Kylin instance and two receivers.

Design test case

  • Create a streaming cube.
  • Enable streaming cube and reassign cube replica set.

@zhangayqian
Copy link
Contributor

Verify test case

  • Ressign cube replica set(Invalid. Partition 5 is assigned to two replica set at the same time)

image

- Ressign cube replica set(Valid)

image

@zhangayqian
Copy link
Contributor

Summary

  • Invalid reassign can be detected and pop up error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants