Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4736 flink upgrade to 1.11.1 #1462

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Conversation

chenjie-sau
Copy link

Proposed changes

flink upgrade to 1.11.1

@chenjie-sau
Copy link
Author

@yanghua could you please take a look when free, thank you

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6483

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.002%) to 28.048%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java 1 16.83%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java 1 56.82%
tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java 2 78.95%
Totals Coverage Status
Change from base Build 6464: -0.002%
Covered Lines: 26253
Relevant Lines: 93600

💛 - Coveralls

@chenjie-sau chenjie-sau changed the title [Kylin-4736] flink upgrade to 1.11.1 and Solve the problem of file closing early in cdh5 [Kylin-4736] flink upgrade to 1.11.1 Oct 24, 2020
Copy link

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @zhangayqian Would you please help to review this new PR?

@zhangayqian
Copy link
Contributor

@chenjie-sau @yanghua Thanks!LGTM,works well in my local env (cdh57).

@yanghua yanghua changed the title [Kylin-4736] flink upgrade to 1.11.1 Kylin-4736 flink upgrade to 1.11.1 Oct 27, 2020
@yanghua yanghua changed the title Kylin-4736 flink upgrade to 1.11.1 KYLIN-4736 flink upgrade to 1.11.1 Oct 27, 2020
@yanghua yanghua merged commit 2353abe into apache:master Oct 27, 2020
@@ -64,12 +64,14 @@ public static Configuration getCurrentConfiguration() {
return conf;
}
Configuration conf = hadoopConfig.get();
conf.set("fs.hdfs.impl.disable.cache", "true");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it needs to add this parameter here? and will it impact other functions, because there are some place calling this functions?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This configuration will not affect other functions, it has been verified,This is done in order to prevent the FileSystem from shutting down prematurely, resulting in abnormal file information acquisition

hit-lacus pushed a commit to hit-lacus/kylin that referenced this pull request Apr 19, 2021
hit-lacus added a commit to hit-lacus/kylin that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants