Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3398 Fix inaccurate arithmetic operations #152

Merged
merged 1 commit into from
Jun 10, 2018

Conversation

nichunen
Copy link

In LookupTableToHFileJob#calculateShardNum

@asfgit
Copy link

asfgit commented Jun 10, 2018

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #152 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #152      +/-   ##
============================================
+ Coverage     22.14%   22.14%   +<.01%     
- Complexity     4019     4020       +1     
============================================
  Files          1012     1012              
  Lines         61207    61207              
  Branches       8768     8768              
============================================
+ Hits          13552    13553       +1     
  Misses        46414    46414              
+ Partials       1241     1240       -1
Impacted Files Coverage Δ Complexity Δ
...in/storage/hbase/lookup/LookupTableToHFileJob.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.6% <0%> (-0.61%) 7% <0%> (ø)
...a/org/apache/kylin/dict/Number2BytesConverter.java 82.53% <0%> (+0.79%) 18% <0%> (+1%) ⬆️
...g/apache/kylin/source/datagen/ColumnGenerator.java 72.29% <0%> (+1.35%) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93247fa...d50873b. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3215

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 24.172%

Changes Missing Coverage Covered Lines Changed/Added Lines %
storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/LookupTableToHFileJob.java 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 1 78.12%
Totals Coverage Status
Change from base Build 3213: 0.0%
Covered Lines: 14795
Relevant Lines: 61207

💛 - Coveralls

@shaofengshi shaofengshi merged commit ff122eb into apache:master Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants