-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KYLIN-4855 kylin.metrics.prefix bug fix #1536
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1536 +/- ##
============================================
- Coverage 25.51% 25.41% -0.10%
+ Complexity 6765 6763 -2
============================================
Files 1505 1508 +3
Lines 93632 93918 +286
Branches 13117 13158 +41
============================================
- Hits 23886 23872 -14
- Misses 67370 67664 +294
- Partials 2376 2382 +6
Continue to review full report at Codecov.
|
Good job @wolfboys , I will check it later! |
LGTM and test passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @wolfboys for contributions, thanks @zhangayqian for verification. |
* KYLIN-4855 kylin.metrics.prefix bug fix * KYLIN-4855 kylin.metrics.prefix bug fix
* KYLIN-4855 kylin.metrics.prefix bug fix * KYLIN-4855 kylin.metrics.prefix bug fix (cherry picked from commit d1c99d7)
* KYLIN-4855 kylin.metrics.prefix bug fix * KYLIN-4855 kylin.metrics.prefix bug fix (cherry picked from commit d1c99d7)
* KYLIN-4855 kylin.metrics.prefix bug fix * KYLIN-4855 kylin.metrics.prefix bug fix (cherry picked from commit d1c99d7)
* KYLIN-4855 kylin.metrics.prefix bug fix * KYLIN-4855 kylin.metrics.prefix bug fix
Proposed changes
After executed "system-cube.sh cron", the system cube will be added to the crontab, but the cube name is wrong, and it does not match the actual situation. After testing, it is found that the system-cube is
There is a bug in the handling of kylin metrics prefix
In system-cube.sh, the prefix is "KYLIN". The logic is wrong. You should get "kylin.metrics.prefix" from kylin.properties. If this item is set, take the value set by the user, if not set, go to the default value. "KYLIN"
In bin/build-incremental-cube.sh The username and password default value ADMIN:KYLIN, if the password has been changed, it will not work
Types of changes
What types of changes does your code introduce to Kylin?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.document
branchFurther comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...