Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4855 kylin.metrics.prefix bug fix #1536

Merged
merged 2 commits into from
Feb 22, 2021
Merged

KYLIN-4855 kylin.metrics.prefix bug fix #1536

merged 2 commits into from
Feb 22, 2021

Conversation

wolfboys
Copy link
Member

@wolfboys wolfboys commented Jan 4, 2021

Proposed changes

After executed "system-cube.sh cron", the system cube will be added to the crontab, but the cube name is wrong, and it does not match the actual situation. After testing, it is found that the system-cube is
There is a bug in the handling of kylin metrics prefix

In system-cube.sh, the prefix is "KYLIN". The logic is wrong. You should get "kylin.metrics.prefix" from kylin.properties. If this item is set, take the value set by the user, if not set, go to the default value. "KYLIN"

In bin/build-incremental-cube.sh The username and password default value ADMIN:KYLIN, if the password has been changed, it will not work

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-io
Copy link

Codecov Report

Merging #1536 (be98fd8) into master (47f8e54) will decrease coverage by 0.09%.
The diff coverage is 1.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1536      +/-   ##
============================================
- Coverage     25.51%   25.41%   -0.10%     
+ Complexity     6765     6763       -2     
============================================
  Files          1505     1508       +3     
  Lines         93632    93918     +286     
  Branches      13117    13158      +41     
============================================
- Hits          23886    23872      -14     
- Misses        67370    67664     +294     
- Partials       2376     2382       +6     
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/kylin/common/KylinConfigBase.java 12.46% <0.00%> (-0.05%) 51.00 <0.00> (ø)
...n/java/org/apache/kylin/common/util/ClassUtil.java 49.20% <0.00%> (-2.47%) 9.00 <0.00> (ø)
.../java/org/apache/kylin/job/util/JobRestClient.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...che/kylin/engine/spark/SparkMergingDictionary.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...g/apache/kylin/query/relnode/OLAPAggregateRel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../org/apache/kylin/query/relnode/OLAPFilterRel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../org/apache/kylin/query/relnode/OLAPWindowRel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../query/relnode/visitor/TupleExpressionVisitor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...torage/hbase/steps/HBaseFlinkOutputTransition.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...che/kylin/storage/hbase/steps/HBaseFlinkSteps.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c12d08...be98fd8. Read the comment docs.

@hit-lacus
Copy link
Member

Good job @wolfboys , I will check it later!

@hit-lacus hit-lacus added the Reviewing Reviewer is trying to review this patch. label Feb 20, 2021
@zhangayqian
Copy link
Contributor

LGTM and test passed.

Copy link
Member

@hit-lacus hit-lacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hit-lacus
Copy link
Member

Thanks @wolfboys for contributions, thanks @zhangayqian for verification.

@hit-lacus hit-lacus merged commit d1c99d7 into apache:master Feb 22, 2021
hit-lacus pushed a commit to hit-lacus/kylin that referenced this pull request Apr 19, 2021
* KYLIN-4855 kylin.metrics.prefix bug fix

* KYLIN-4855 kylin.metrics.prefix bug fix
zhangayqian pushed a commit to zhangayqian/kylin that referenced this pull request Jun 11, 2021
* KYLIN-4855 kylin.metrics.prefix bug fix

* KYLIN-4855 kylin.metrics.prefix bug fix

(cherry picked from commit d1c99d7)
zhangayqian pushed a commit to zhangayqian/kylin that referenced this pull request Jun 11, 2021
* KYLIN-4855 kylin.metrics.prefix bug fix

* KYLIN-4855 kylin.metrics.prefix bug fix

(cherry picked from commit d1c99d7)
hit-lacus pushed a commit that referenced this pull request Jun 27, 2021
* KYLIN-4855 kylin.metrics.prefix bug fix

* KYLIN-4855 kylin.metrics.prefix bug fix

(cherry picked from commit d1c99d7)
zhangayqian pushed a commit that referenced this pull request Nov 5, 2021
* KYLIN-4855 kylin.metrics.prefix bug fix

* KYLIN-4855 kylin.metrics.prefix bug fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewing Reviewer is trying to review this patch.
Projects
None yet
4 participants