New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KYLIN-3434 Support prepare statement in Kylin server side #160
Conversation
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
============================================
- Coverage 22.44% 22.39% -0.06%
- Complexity 4154 4155 +1
============================================
Files 1034 1034
Lines 62181 62271 +90
Branches 8907 8921 +14
============================================
- Hits 13957 13946 -11
- Misses 46903 46998 +95
- Partials 1321 1327 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gang, this is a nice enhancement; Could you please add UT for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
support cache preparedStatement in kylin sever, to save sql parse/optimize/implement time. Detail information can see in: https://issues.apache.org/jira/browse/KYLIN-3434