Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3434 Support prepare statement in Kylin server side #160

Merged
merged 1 commit into from Aug 14, 2018

Conversation

allenma
Copy link

@allenma allenma commented Jul 2, 2018

support cache preparedStatement in kylin sever, to save sql parse/optimize/implement time. Detail information can see in: https://issues.apache.org/jira/browse/KYLIN-3434

@asfgit
Copy link

asfgit commented Jul 2, 2018

Can one of the admins verify this patch?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3287

  • 1 of 133 (0.75%) changed or added relevant lines in 5 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 24.53%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java 0 2 0.0%
core-metadata/src/main/java/org/apache/kylin/metadata/project/ProjectManager.java 0 4 0.0%
server-base/src/main/java/org/apache/kylin/rest/request/PrepareSqlRequest.java 0 4 0.0%
server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java 0 122 0.0%
Files with Coverage Reduction New Missed Lines %
core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java 1 81.08%
server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java 2 0.0%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 7 76.29%
Totals Coverage Status
Change from base Build 3285: -0.04%
Covered Lines: 15275
Relevant Lines: 62271

💛 - Coveralls

@codecov-io
Copy link

Codecov Report

Merging #160 into master will decrease coverage by 0.05%.
The diff coverage is 0.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #160      +/-   ##
============================================
- Coverage     22.44%   22.39%   -0.06%     
- Complexity     4154     4155       +1     
============================================
  Files          1034     1034              
  Lines         62181    62271      +90     
  Branches       8907     8921      +14     
============================================
- Hits          13957    13946      -11     
- Misses        46903    46998      +95     
- Partials       1321     1327       +6
Impacted Files Coverage Δ Complexity Δ
...va/org/apache/kylin/rest/service/QueryService.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../java/org/apache/kylin/common/KylinConfigBase.java 14.57% <0%> (-0.06%) 35 <0> (ø)
.../apache/kylin/metadata/project/ProjectManager.java 10.52% <0%> (-0.21%) 7 <0> (ø)
...g/apache/kylin/rest/request/PrepareSqlRequest.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...c/main/java/org/apache/kylin/cube/CubeManager.java 40.8% <100%> (+0.1%) 42 <0> (ø) ⬇️
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 66.56% <0%> (-3.65%) 7% <0%> (ø)
...g/apache/kylin/source/datagen/ColumnGenerator.java 70.94% <0%> (-1.36%) 8% <0%> (ø)
...a/org/apache/kylin/dict/Number2BytesConverter.java 81.74% <0%> (-0.8%) 17% <0%> (-1%)
...ain/java/org/apache/kylin/cube/model/CubeDesc.java 64.46% <0%> (+0.13%) 176% <0%> (+1%) ⬆️
.../main/java/org/apache/kylin/cube/CubeInstance.java 39.11% <0%> (+0.36%) 51% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c1d902...08d657e. Read the comment docs.

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gang, this is a nice enhancement; Could you please add UT for it?

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit 367fdfb into apache:master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants