Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4921: New rowkey for streamv2 source config and fix bug that can't create same name table in diff project #1604

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

liukun4515
Copy link
Contributor

@liukun4515 liukun4515 commented Mar 8, 2021

Proposed changes

use the new row key path to identify the stream source config path.
fix the bug: the other stream source config will be deleted by mistake, when creating the stream table failed.

The design doc

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@liukun4515
Copy link
Contributor Author

@hit-lacus PTAL

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6949

  • 4 of 85 (4.71%) changed or added relevant lines in 12 files are covered.
  • 13 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.01%) to 27.942%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server-base/src/main/java/org/apache/kylin/rest/controller/TableController.java 0 1 0.0%
server-base/src/main/java/org/apache/kylin/rest/service/ProjectService.java 0 1 0.0%
stream-receiver/src/main/java/org/apache/kylin/stream/server/StreamingServer.java 0 1 0.0%
stream-source-kafka/src/main/java/org/apache/kylin/stream/source/kafka/KafkaBatchSourceAdaptor.java 0 1 0.0%
server-base/src/main/java/org/apache/kylin/rest/service/TableService.java 0 2 0.0%
server-base/src/main/java/org/apache/kylin/rest/service/StreamingV2Service.java 0 4 0.0%
stream-source-kafka/src/main/java/org/apache/kylin/stream/source/kafka/KafkaSource.java 0 5 0.0%
stream-core/src/main/java/org/apache/kylin/stream/core/source/StreamingSourceConfig.java 0 8 0.0%
tool/src/main/java/org/apache/kylin/tool/CubeMigrationCLI.java 0 9 0.0%
server-base/src/main/java/org/apache/kylin/rest/controller/StreamingV2Controller.java 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
server-base/src/main/java/org/apache/kylin/rest/controller/StreamingV2Controller.java 1 0%
server-base/src/main/java/org/apache/kylin/rest/service/TableService.java 1 10.89%
tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java 1 81.58%
stream-core/src/main/java/org/apache/kylin/stream/core/source/StreamingSourceConfigManager.java 2 0%
tool/src/main/java/org/apache/kylin/tool/CubeMigrationCLI.java 3 0%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
Totals Coverage Status
Change from base Build 6948: -0.01%
Covered Lines: 26255
Relevant Lines: 93961

💛 - Coveralls

@liukun4515 liukun4515 marked this pull request as draft March 11, 2021 08:11
Copy link
Member

@hit-lacus hit-lacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@liukun4515
Copy link
Contributor Author

The design doc

@liukun4515 liukun4515 marked this pull request as ready for review March 17, 2021 03:50
@liukun4515
Copy link
Contributor Author

@xiaowangyu I have added the design doc, PTAL

Copy link
Member

@hit-lacus hit-lacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New dev documentation looks great to me, could please copy them to related JIRA issue page, thank you.

@hit-lacus hit-lacus merged commit decb4ab into apache:master Mar 18, 2021
hit-lacus pushed a commit to hit-lacus/kylin that referenced this pull request Apr 19, 2021
…n't create same name table in diff project (apache#1604)

* support diff project with same stream name

* fix bug: when create duplicated table, the original stream table can't be deleted
zhangayqian pushed a commit that referenced this pull request Nov 5, 2021
…n't create same name table in diff project (#1604)

* support diff project with same stream name

* fix bug: when create duplicated table, the original stream table can't be deleted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kylin 3.X Kylin 3.X
Projects
None yet
3 participants