-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KYLIN-4921: New rowkey for streamv2 source config and fix bug that can't create same name table in diff project #1604
Conversation
@hit-lacus PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
@xiaowangyu I have added the design doc, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New dev documentation looks great to me, could please copy them to related JIRA issue page, thank you.
…n't create same name table in diff project (apache#1604) * support diff project with same stream name * fix bug: when create duplicated table, the original stream table can't be deleted
…n't create same name table in diff project (#1604) * support diff project with same stream name * fix bug: when create duplicated table, the original stream table can't be deleted
Proposed changes
use the new row key path to identify the stream source config path.
fix the bug: the other stream source config will be deleted by mistake, when creating the stream table failed.
The design doc
Types of changes
What types of changes does your code introduce to Kylin?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.document
branchFurther comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...