KYLIN-4929 skip update metrics for queries that hit no realization #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1605 +/- ##
============================================
- Coverage 25.42% 25.40% -0.02%
+ Complexity 6765 6764 -1
============================================
Files 1508 1508
Lines 93918 93925 +7
Branches 13158 13161 +3
============================================
- Hits 23877 23865 -12
- Misses 67662 67678 +16
- Partials 2379 2382 +3
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 6957
💛 - Coveralls |
xiacongling
changed the title
zzcclp
reviewed
Mar 11, 2021
server-base/src/main/java/org/apache/kylin/rest/metrics/QueryMetricsFacade.java
Outdated
Show resolved
Hide resolved
hit-lacus
pushed a commit
to hit-lacus/kylin
that referenced
this pull request
Apr 19, 2021
…pache#1605) * skip update metrics for queries that hit no realization * use string empty check
zhangayqian
pushed a commit
to zhangayqian/kylin
that referenced
this pull request
Jun 11, 2021
…pache#1605) * skip update metrics for queries that hit no realization * use string empty check (cherry picked from commit 448d38a)
zhangayqian
pushed a commit
to zhangayqian/kylin
that referenced
this pull request
Jun 11, 2021
…pache#1605) * skip update metrics for queries that hit no realization * use string empty check (cherry picked from commit 448d38a)
zhangayqian
pushed a commit
that referenced
this pull request
Nov 5, 2021
…1605) * skip update metrics for queries that hit no realization * use string empty check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.documentbranch