Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYLIN-4971] Add new measure bitmap_map for count distinct at fronten… #1633

Merged
merged 1 commit into from May 8, 2021

Conversation

Ted-Jiang
Copy link
Member

…d. (#222)

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@Ted-Jiang
Copy link
Member Author

Add bitmap_map measure.
image
only support segmentBuilder and auto add in Advanced Dict UI
image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7070

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.001%) to 28.094%

Files with Coverage Reduction New Missed Lines %
core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java 1 81.08%
server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java 1 47.62%
Totals Coverage Status
Change from base Build 7067: 0.001%
Covered Lines: 26715
Relevant Lines: 95091

💛 - Coveralls

@hit-lacus hit-lacus added the Kylin 3.X Kylin 3.X label Apr 14, 2021
Copy link
Contributor

@zhangayqian zhangayqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Additional distinct column in this measure: item should be hidden in bitmap_map measure, because precise count distinct does not support multiple column distinct count.
image

@hit-lacus hit-lacus added the Not 4.X Not applicable for Parquet Storage label Apr 21, 2021
@Ted-Jiang
Copy link
Member Author

@zhangayqian thxs, already fix.
image

@zhangayqian
Copy link
Contributor

@Ted-Jiang Nice!Can you merge this two commit to one commit?

@Ted-Jiang
Copy link
Member Author

@Ted-Jiang Nice!Can you merge this two commit to one commit?

sure,fix

@zhangayqian
Copy link
Contributor

LGTM

@hit-lacus hit-lacus merged commit b577521 into apache:master May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kylin 3.X Kylin 3.X Not 4.X Not applicable for Parquet Storage
Projects
None yet
4 participants