Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4974 Kylin does not handle fucntion CURRENT_TIME(). #1637

Merged
merged 7 commits into from Nov 3, 2021

Conversation

Sidonet
Copy link

@Sidonet Sidonet commented Apr 15, 2021

Proposed changes

Add time serializer.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • [x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7080

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 13 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.005%) to 28.089%

Files with Coverage Reduction New Missed Lines %
core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java 1 81.08%
server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java 1 47.62%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java 1 56.82%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java 5 66.67%
Totals Coverage Status
Change from base Build 7067: -0.005%
Covered Lines: 26710
Relevant Lines: 95092

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #1637 (b9b2f4f) into kylin3 (fef7803) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             kylin3    #1637   +/-   ##
=========================================
  Coverage     25.12%   25.12%           
  Complexity     6775     6775           
=========================================
  Files          1518     1518           
  Lines         95184    95185    +1     
  Branches      13294    13294           
=========================================
+ Hits          23917    23918    +1     
+ Misses        68888    68887    -1     
- Partials       2379     2380    +1     
Impacted Files Coverage Δ
...he/kylin/metadata/datatype/DataTypeSerializer.java 63.41% <100.00%> (+0.91%) ⬆️
.../apache/kylin/tool/query/ProbabilityGenerator.java 71.05% <0.00%> (-5.27%) ⬇️
...ream/core/storage/columnar/ColumnarStoreCache.java 52.27% <0.00%> (-3.41%) ⬇️
...he/kylin/job/impl/threadpool/DefaultScheduler.java 75.86% <0.00%> (+2.29%) ⬆️
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 66.15% <0.00%> (+2.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fef7803...b9b2f4f. Read the comment docs.

@zhangayqian
Copy link
Contributor

LGTM

@zhangayqian zhangayqian merged commit 018e2d7 into apache:kylin3 Nov 3, 2021
zhangayqian pushed a commit that referenced this pull request Nov 5, 2021
…n. (#1637)

Co-authored-by: alexandr.sidorchuk <alexandr.sidorchuk@apm-consult.com>
fengpod pushed a commit to fengpod/kylin that referenced this pull request Dec 8, 2021
…n. (apache#1637)

Co-authored-by: alexandr.sidorchuk <alexandr.sidorchuk@apm-consult.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants