New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KYLIN-4974 Kylin does not handle fucntion CURRENT_TIME(). #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebase from source
Update from repo
Pull Request Test Coverage Report for Build 7080
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## kylin3 #1637 +/- ##
=========================================
Coverage 25.12% 25.12%
Complexity 6775 6775
=========================================
Files 1518 1518
Lines 95184 95185 +1
Branches 13294 13294
=========================================
+ Hits 23917 23918 +1
+ Misses 68888 68887 -1
- Partials 2379 2380 +1
Continue to review full report at Codecov.
|
LGTM |
zhangayqian
pushed a commit
that referenced
this pull request
Nov 5, 2021
…n. (#1637) Co-authored-by: alexandr.sidorchuk <alexandr.sidorchuk@apm-consult.com>
fengpod
pushed a commit
to fengpod/kylin
that referenced
this pull request
Dec 8, 2021
…n. (apache#1637) Co-authored-by: alexandr.sidorchuk <alexandr.sidorchuk@apm-consult.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add time serializer.
Types of changes
What types of changes does your code introduce to Kylin?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.document
branchFurther comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...