KYLIN-4980 Support prunning segments from complex filter co… #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengshengjun
force-pushed
the
KYLIN-4980
branch
from
189a908
to
546c1b9
Compare
hit-lacus
added
Kylin 4.X
zhengshengjun
force-pushed
the
KYLIN-4980
branch
2 times, most recently
from
71224b7
to
9b91ddb
Compare
zhengshengjun
changed the title
|
Added test case |
zzcclp
reviewed
Apr 24, 2021
| } | ||
| case _ => | ||
| //other unary filter like EqualTo, GreaterThan, GreaterThanOrEqual, etc. | ||
| if (filter.references.contains(col)) { |
There was a problem hiding this comment.
better to use if (filter.references.subsetOf(AttributeSet(col))) {
zhengshengjun
force-pushed
the
KYLIN-4980
branch
from
9b91ddb
to
92e15ba
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nditions
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.documentbranchFurther comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...