Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3259 when delete cube, remove it from hybrid #176

Merged
merged 1 commit into from Jul 26, 2018

Conversation

Wayne1c
Copy link

@Wayne1c Wayne1c commented Jul 25, 2018

No description provided.

@asfgit
Copy link

asfgit commented Jul 25, 2018

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #176 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #176      +/-   ##
============================================
- Coverage     22.49%   22.45%   -0.04%     
+ Complexity     4238     4237       -1     
============================================
  Files          1050     1050              
  Lines         62743    62785      +42     
  Branches       8962     8970       +8     
============================================
- Hits          14111    14100      -11     
- Misses        47282    47330      +48     
- Partials       1350     1355       +5
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/kylin/rest/job/HybridCubeCLI.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/org/apache/kylin/rest/service/HybridService.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/org/apache/kylin/rest/service/CubeService.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rg/apache/kylin/storage/hybrid/HybridInstance.java 39.37% <0%> (-0.79%) 13 <0> (ø)
...org/apache/kylin/rest/util/QueryRequestLimits.java 35.71% <0%> (-4.77%) 5% <0%> (-1%)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 66.56% <0%> (-3.65%) 7% <0%> (ø)
...lin/dict/lookup/cache/RocksDBLookupTableCache.java 76.68% <0%> (+0.51%) 27% <0%> (ø) ⬇️
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 66.15% <0%> (+2.3%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9d9b2e...44b8055. Read the comment docs.

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit f27a92b into apache:master Jul 26, 2018
Ted-Jiang added a commit to Ted-Jiang/kylin that referenced this pull request Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants