Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KYLIN-3582 String compare should use equals method #244

Merged
merged 1 commit into from
Sep 25, 2018
Merged

KYLIN-3582 String compare should use equals method #244

merged 1 commit into from
Sep 25, 2018

Conversation

hit-lacus
Copy link
Member

No description provided.

@asfgit
Copy link

asfgit commented Sep 24, 2018

Can one of the admins verify this patch?

1 similar comment
@asfgit
Copy link

asfgit commented Sep 24, 2018

Can one of the admins verify this patch?

shaofengshi
shaofengshi approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit d8c2a28 into apache:master Sep 25, 2018
@hit-lacus hit-lacus deleted the KYLIN-3582 branch September 29, 2018 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaofengshi shaofengshi shaofengshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hit-lacus @asfgit @shaofengshi