Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3583, KYLIN-3579 #251

Merged
merged 2 commits into from Sep 30, 2018
Merged

KYLIN-3583, KYLIN-3579 #251

merged 2 commits into from Sep 30, 2018

Conversation

Wayne1c
Copy link

@Wayne1c Wayne1c commented Sep 25, 2018

No description provided.

@asfgit
Copy link

asfgit commented Sep 25, 2018

Can one of the admins verify this patch?

1 similar comment
@asfgit
Copy link

asfgit commented Sep 25, 2018

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Sep 25, 2018

Pull Request Test Coverage Report for Build 3648

  • 0 of 175 (0.0%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 23.068%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/RecordEventTimeDetail.java 0 1 0.0%
core-cube/src/main/java/org/apache/kylin/cube/gridtable/CubeCodeSystem.java 0 4 0.0%
core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/BPUSCalculator.java 0 7 0.0%
core-common/src/main/java/org/apache/kylin/common/metrics/metrics2/HadoopMetrics2Reporter.java 0 163 0.0%
Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/BPUSCalculator.java 1 0.0%
core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java 2 68.46%
Totals Coverage Status
Change from base Build 3641: -0.05%
Covered Lines: 16157
Relevant Lines: 70040

💛 - Coveralls

@Wayne1c Wayne1c changed the title Fix bug KYLIN-3583, KYLIN-3560, KYLIN-3579 Sep 26, 2018
@Wayne1c Wayne1c changed the title KYLIN-3583, KYLIN-3560, KYLIN-3579 KYLIN-3583, KYLIN-3579 Sep 30, 2018
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f42e937). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #251   +/-   ##
=========================================
  Coverage          ?   21.15%           
  Complexity        ?     4404           
=========================================
  Files             ?     1086           
  Lines             ?    69801           
  Branches          ?    10110           
=========================================
  Hits              ?    14763           
  Misses            ?    53638           
  Partials          ?     1400
Impacted Files Coverage Δ Complexity Δ
.../kylin/metrics/lib/impl/RecordEventTimeDetail.java 0% <0%> (ø) 0 <0> (?)
...rg/apache/kylin/cube/gridtable/CubeCodeSystem.java 25.37% <0%> (ø) 8 <0> (?)
...he/kylin/cube/cuboid/algorithm/BPUSCalculator.java 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f42e937...6bdbe40. Read the comment docs.

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit 8db0330 into apache:master Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants